feat: add rounding functions with decimal type args #671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scgkiran
requested review from
EpsilonPrime,
cpcloud,
jacques-n,
vbarua and
westonpace
as code owners
jacques-n
requested changes
Jul 28, 2024
extensions/functions_rounding.yaml
Outdated
| values: [ TIE_TO_EVEN, TIE_AWAY_FROM_ZERO, TRUNCATE, CEILING, FLOOR, | ||
| AWAY_FROM_ZERO, TIE_DOWN, TIE_UP, TIE_TOWARDS_ZERO, TIE_TO_ODD ] | ||
| nullability: DECLARED_OUTPUT | ||
| return: decimal?<P1,S2> |
There was a problem hiding this comment.
where does s2 come from?
jacques-n
reviewed
Jul 30, 2024
extensions/functions_rounding.yaml
Outdated
| AWAY_FROM_ZERO, TIE_DOWN, TIE_UP, TIE_TOWARDS_ZERO, TIE_TO_ODD ] | ||
| nullability: DECLARED_OUTPUT | ||
| return: |- | ||
| S2 = iff(s > 0, s, 0) |
There was a problem hiding this comment.
output type derivation doesn't support referring to argument values. we've talked about supporting constant arguments but I don't think we've added to spec, have we?
jacques-n
added
the
awaiting-user-input
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.